lvyanquan commented on code in PR #5486:
URL: https://github.com/apache/iceberg/pull/5486#discussion_r950691579
##########
flink/v1.14/flink/src/test/java/org/apache/iceberg/flink/TestFlinkUpsert.java:
##########
@@ -168,30 +167,31 @@ public void testUpsertAndQuery() {
@Test
public void testPrimaryKeyEqualToPartitionKey() {
// This is an SQL based reproduction of
TestFlinkIcebergSinkV2#testUpsertOnDataKey
- String tableName = "upsert_on_data_key";
+ String tableName = "upsert_on_id_key";
try {
sql(
- "CREATE TABLE %s(id INT NOT NULL, data STRING NOT NULL, PRIMARY
KEY(data) NOT ENFORCED) "
- + "PARTITIONED BY (data) WITH %s",
+ "CREATE TABLE %s(id INT NOT NULL, name STRING NOT NULL, PRIMARY
KEY(id) NOT ENFORCED) "
+ + "PARTITIONED BY (id) WITH %s",
tableName, toWithClause(tableUpsertProps));
- sql("INSERT INTO %s VALUES " + "(1, 'aaa')," + "(2, 'aaa')," + "(3,
'bbb')", tableName);
+ sql("INSERT INTO %s VALUES " + "(1, 'Bill')," + "(1, 'Jane')," + "(2,
'Bill')", tableName);
TestHelpers.assertRows(
sql("SELECT * FROM %s", tableName),
- Lists.newArrayList(Row.of(2, "aaa"), Row.of(3, "bbb")));
+ Lists.newArrayList(Row.of(1, "Jane"), Row.of(2, "Bill")));
- sql("INSERT INTO %s VALUES " + "(4, 'aaa')," + "(5, 'bbb')", tableName);
+ sql("INSERT INTO %s VALUES " + "(1, 'Bill')," + "(2, 'Jane')",
tableName);
TestHelpers.assertRows(
sql("SELECT * FROM %s", tableName),
- Lists.newArrayList(Row.of(4, "aaa"), Row.of(5, "bbb")));
+ Lists.newArrayList(Row.of(1, "Bill"), Row.of(2, "Jane")));
- sql("INSERT INTO %s VALUES " + "(6, 'aaa')," + "(7, 'bbb')", tableName);
+ sql("INSERT INTO %s VALUES " + "(3, 'Bill')," + "(4, 'Jane')",
tableName);
Review Comment:
I think these two lines have the same function as before lines, so I changed
it to the case where the column values are not the same
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
