rdblue commented on code in PR #6525: URL: https://github.com/apache/iceberg/pull/6525#discussion_r1067581319
########## python/tests/test_typedef.py: ########## @@ -46,7 +51,8 @@ def test_record_repr() -> None: def test_named_record() -> None: - r = Record(fields=(NestedField(0, "id", IntegerType()), NestedField(1, "name", StringType()))) + r = Record() + r.set_record_schema(StructType(NestedField(0, "id", IntegerType()), NestedField(1, "name", StringType()))) Review Comment: I think I prefer passing the schema into the constructor. We may want to keep doing that, at least for the generic record. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
