rdblue commented on code in PR #6525:
URL: https://github.com/apache/iceberg/pull/6525#discussion_r1068424239
##########
python/pyiceberg/typedef.py:
##########
@@ -85,7 +79,7 @@ class StructProtocol(Protocol): # pragma: no cover
"""A generic protocol used by accessors to get and set at positions of an
object"""
@abstractmethod
- def set_record_schema(self, record_schema: StructType) -> None:
+ def __init__(self, record_schema: Optional[StructType] = None, **data:
Any) -> None:
Review Comment:
Do we need this change to `StructProtocol` or can we make the change to
`Record` only?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
