rdblue commented on code in PR #6525:
URL: https://github.com/apache/iceberg/pull/6525#discussion_r1068425096
##########
python/tests/expressions/test_evaluator.py:
##########
@@ -54,110 +54,110 @@
def test_true() -> None:
evaluate = expression_evaluator(SIMPLE_SCHEMA, AlwaysTrue(),
case_sensitive=True)
- assert evaluate(Record.of(1, "a"))
+ assert evaluate(Record(a=1, b="a"))
def test_false() -> None:
evaluate = expression_evaluator(SIMPLE_SCHEMA, AlwaysFalse(),
case_sensitive=True)
- assert not evaluate(Record.of(1, "a"))
+ assert not evaluate(Record(a=1, b="a"))
def test_less_than() -> None:
evaluate = expression_evaluator(SIMPLE_SCHEMA, LessThan("id", 3),
case_sensitive=True)
- assert evaluate(Record.of(2, "a"))
- assert not evaluate(Record.of(3, "a"))
+ assert evaluate(Record(a=2, b="a"))
+ assert not evaluate(Record(a=3, b="a"))
def test_less_than_or_equal() -> None:
evaluate = expression_evaluator(SIMPLE_SCHEMA, LessThanOrEqual("id", 3),
case_sensitive=True)
- assert evaluate(Record.of(1, "a"))
- assert evaluate(Record.of(3, "a"))
- assert not evaluate(Record.of(4, "a"))
+ assert evaluate(Record(a=1, b="a"))
+ assert evaluate(Record(a=3, b="a"))
+ assert not evaluate(Record(a=4, b="a"))
def test_greater_than() -> None:
evaluate = expression_evaluator(SIMPLE_SCHEMA, GreaterThan("id", 3),
case_sensitive=True)
- assert not evaluate(Record.of(1, "a"))
- assert not evaluate(Record.of(3, "a"))
- assert evaluate(Record.of(4, "a"))
+ assert not evaluate(Record(a=1, b="a"))
+ assert not evaluate(Record(a=3, b="a"))
+ assert evaluate(Record(a=4, b="a"))
def test_greater_than_or_equal() -> None:
evaluate = expression_evaluator(SIMPLE_SCHEMA, GreaterThanOrEqual("id",
3), case_sensitive=True)
- assert not evaluate(Record.of(2, "a"))
- assert evaluate(Record.of(3, "a"))
- assert evaluate(Record.of(4, "a"))
+ assert not evaluate(Record(a=2, b="a"))
+ assert evaluate(Record(a=3, b="a"))
+ assert evaluate(Record(a=4, b="a"))
def test_equal_to() -> None:
evaluate = expression_evaluator(SIMPLE_SCHEMA, EqualTo("id", 3),
case_sensitive=True)
- assert not evaluate(Record.of(2, "a"))
- assert evaluate(Record.of(3, "a"))
- assert not evaluate(Record.of(4, "a"))
+ assert not evaluate(Record(a=2, b="a"))
+ assert evaluate(Record(a=3, b="a"))
+ assert not evaluate(Record(a=4, b="a"))
def test_not_equal_to() -> None:
evaluate = expression_evaluator(SIMPLE_SCHEMA, NotEqualTo("id", 3),
case_sensitive=True)
- assert evaluate(Record.of(2, "a"))
- assert not evaluate(Record.of(3, "a"))
- assert evaluate(Record.of(4, "a"))
+ assert evaluate(Record(a=2, b="a"))
+ assert not evaluate(Record(a=3, b="a"))
+ assert evaluate(Record(a=4, b="a"))
def test_in() -> None:
evaluate = expression_evaluator(SIMPLE_SCHEMA, In("id", [1, 2, 3]),
case_sensitive=True)
- assert evaluate(Record.of(2, "a"))
- assert evaluate(Record.of(3, "a"))
- assert not evaluate(Record.of(4, "a"))
+ assert evaluate(Record(a=2, b="a"))
+ assert evaluate(Record(a=3, b="a"))
+ assert not evaluate(Record(a=4, b="a"))
def test_not_in() -> None:
evaluate = expression_evaluator(SIMPLE_SCHEMA, NotIn("id", [1, 2, 3]),
case_sensitive=True)
- assert not evaluate(Record.of(2, "a"))
- assert not evaluate(Record.of(3, "a"))
- assert evaluate(Record.of(4, "a"))
+ assert not evaluate(Record(a=2, b="a"))
+ assert not evaluate(Record(a=3, b="a"))
+ assert evaluate(Record(a=4, b="a"))
def test_is_null() -> None:
evaluate = expression_evaluator(SIMPLE_SCHEMA, IsNull("data"),
case_sensitive=True)
- assert not evaluate(Record.of(2, "a"))
- assert evaluate(Record.of(3, None))
+ assert not evaluate(Record(a=2, b="a"))
+ assert evaluate(Record(a=3, b=None))
def test_not_null() -> None:
evaluate = expression_evaluator(SIMPLE_SCHEMA, NotNull("data"),
case_sensitive=True)
- assert evaluate(Record.of(2, "a"))
- assert not evaluate(Record.of(3, None))
+ assert evaluate(Record(a=2, b="a"))
+ assert not evaluate(Record(a=3, b=None))
def test_is_nan() -> None:
evaluate = expression_evaluator(FLOAT_SCHEMA, IsNaN("f"),
case_sensitive=True)
- assert not evaluate(Record.of(2, 0.0))
- assert not evaluate(Record.of(3, float("infinity")))
- assert evaluate(Record.of(4, float("nan")))
+ assert not evaluate(Record(a=2, b=0.0))
+ assert not evaluate(Record(a=3, b=float("infinity")))
+ assert evaluate(Record(a=4, b=float("nan")))
def test_not_nan() -> None:
evaluate = expression_evaluator(FLOAT_SCHEMA, NotNaN("f"),
case_sensitive=True)
- assert evaluate(Record.of(2, 0.0))
- assert evaluate(Record.of(3, float("infinity")))
- assert not evaluate(Record.of(4, float("nan")))
+ assert evaluate(Record(a=2, b=0.0))
+ assert evaluate(Record(a=3, b=float("infinity")))
+ assert not evaluate(Record(a=4, b=float("nan")))
def test_not() -> None:
evaluate = expression_evaluator(SIMPLE_SCHEMA, Not(LessThan("id", 3)),
case_sensitive=True)
- assert not evaluate(Record.of(2, "a"))
- assert evaluate(Record.of(3, "a"))
+ assert not evaluate(Record(a=2, b="a"))
+ assert evaluate(Record(a=3, b="a"))
def test_and() -> None:
evaluate = expression_evaluator(SIMPLE_SCHEMA, And(LessThan("id", 3),
GreaterThan("id", 1)), case_sensitive=True)
- assert not evaluate(Record.of(1, "a"))
- assert evaluate(Record.of(2, "a"))
- assert not evaluate(Record.of(3, "a"))
+ assert not evaluate(Record(a=1, b="a"))
+ assert evaluate(Record(a=2, b="a"))
+ assert not evaluate(Record(a=3, b="a"))
def test_or() -> None:
evaluate = expression_evaluator(SIMPLE_SCHEMA, Or(LessThan("id", 2),
GreaterThan("id", 2)), case_sensitive=True)
- assert evaluate(Record.of(1, "a"))
- assert not evaluate(Record.of(2, "a"))
- assert evaluate(Record.of(3, "a"))
+ assert evaluate(Record(a=1, b="a"))
Review Comment:
It's a bit confusing that these names don't align with the expression that
is being evaluated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
