RussellSpitzer commented on code in PR #7275:
URL: https://github.com/apache/iceberg/pull/7275#discussion_r1157745881
##########
core/src/main/java/org/apache/iceberg/catalog/BaseSessionCatalog.java:
##########
@@ -143,6 +143,16 @@ public boolean dropNamespace(Namespace namespace) throws
NamespaceNotEmptyExcept
return BaseSessionCatalog.this.dropNamespace(context, namespace);
}
+ @Override
+ public boolean dropNamespace(Namespace namespace, boolean cascade)
+ throws NamespaceNotEmptyException {
+ if (cascade) {
+ return BaseSessionCatalog.this.dropNamespace(context, namespace, true);
Review Comment:
This is just an infinite regression right?
##########
core/src/main/java/org/apache/iceberg/catalog/BaseSessionCatalog.java:
##########
@@ -143,6 +143,16 @@ public boolean dropNamespace(Namespace namespace) throws
NamespaceNotEmptyExcept
return BaseSessionCatalog.this.dropNamespace(context, namespace);
}
+ @Override
+ public boolean dropNamespace(Namespace namespace, boolean cascade)
+ throws NamespaceNotEmptyException {
+ if (cascade) {
+ return BaseSessionCatalog.this.dropNamespace(context, namespace, true);
Review Comment:
This is just an infinite recursion right?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
