RussellSpitzer commented on code in PR #7275:
URL: https://github.com/apache/iceberg/pull/7275#discussion_r1189112162
##########
api/src/main/java/org/apache/iceberg/catalog/SessionCatalog.java:
##########
@@ -309,6 +309,17 @@ default List<Namespace> listNamespaces(SessionContext
context) {
*/
boolean dropNamespace(SessionContext context, Namespace namespace);
+ /**
+ * Drop a namespace. If the namespace exists and was dropped, this will
return true.
+ *
+ * @param context session context
+ * @param namespace a {@link Namespace namespace}
+ * @param cascade – When true, deletes all objects under the namespace
+ * @return true if the namespace was dropped, false otherwise.
+ * @throws NamespaceNotEmptyException If the namespace is not empty
+ */
+ boolean dropNamespace(SessionContext context, Namespace namespace, boolean
cascade);
Review Comment:
Do we need the default here as well? I think we do for any implementers of
SessionCatalog
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
