RussellSpitzer commented on code in PR #7275:
URL: https://github.com/apache/iceberg/pull/7275#discussion_r1174045218
##########
core/src/test/java/org/apache/iceberg/rest/RESTCatalogAdapter.java:
##########
@@ -363,6 +363,16 @@ public <T extends RESTResponse> T handleRequest(
return null;
}
+ private void dropNamespace(Map<String, String> vars) {
+ Namespace namespace = namespaceFromPathVars(vars);
+ boolean cascade = PropertyUtil.propertyAsBoolean(vars, "cascade", false);
+ if (cascade) {
Review Comment:
Couldn't we always just call the three arg version here? since we can just
call CatalogHandlers.dropNamespace(asNamesapceCatalog, namespace, cascade)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
