RussellSpitzer commented on code in PR #7275:
URL: https://github.com/apache/iceberg/pull/7275#discussion_r1157746889
##########
core/src/main/java/org/apache/iceberg/hadoop/HadoopCatalog.java:
##########
@@ -349,6 +349,17 @@ public boolean dropNamespace(Namespace namespace) {
}
}
+ @Override
+ public boolean dropNamespace(Namespace namespace, boolean cascade)
+ throws NamespaceNotEmptyException {
+ if (cascade) {
+ // recursively delete all nested namespaces
+ listNamespaces(namespace).forEach(n -> dropNamespace(n, true));
Review Comment:
All of the other catalogs do not drop nested namespaces, do we need to cover
this in other cases?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
