RussellSpitzer commented on code in PR #7275:
URL: https://github.com/apache/iceberg/pull/7275#discussion_r1189085128
##########
snowflake/src/main/java/org/apache/iceberg/snowflake/SnowflakeCatalog.java:
##########
@@ -214,6 +214,12 @@ public boolean dropNamespace(Namespace namespace) {
"SnowflakeCatalog does not currently support dropNamespace");
}
+ @Override
+ public boolean dropNamespace(Namespace namespace, boolean cascade) {
Review Comment:
Oh above you would add this with a "default" throw unsupported operation
exception to the api. That way you don't have to add exception throwing code to
all the catalogs that don't implement it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
