atris commented on a change in pull request #904: LUCENE-8992: Share minimum
score across segment in concurrent search
URL: https://github.com/apache/lucene-solr/pull/904#discussion_r329146499
##########
File path: lucene/core/src/java/org/apache/lucene/search/TopFieldCollector.java
##########
@@ -389,14 +406,14 @@ public static TopFieldCollector create(Sort sort, int
numHits, FieldDoc after, i
throw new IllegalArgumentException("totalHitsThreshold must be >= 0, got
" + totalHitsThreshold);
}
- return create(sort, numHits, after,
HitsThresholdChecker.create(totalHitsThreshold));
+ return create(sort, numHits, after,
HitsThresholdChecker.create(totalHitsThreshold), null);
Review comment:
Nit: add a comment explaining the null? like `, null /* bottomValueChecker
*/`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
