atris commented on a change in pull request #904: LUCENE-8992: Share minimum
score across segment in concurrent search
URL: https://github.com/apache/lucene-solr/pull/904#discussion_r329933150
##########
File path:
lucene/core/src/test/org/apache/lucene/search/TestTopDocsCollector.java
##########
@@ -404,44 +424,288 @@ public void testTotalHits() throws Exception {
public void testGlobalScore() throws Exception {
Directory dir = newDirectory();
- RandomIndexWriter writer = new RandomIndexWriter(random(), dir);
- try (LineFileDocs docs = new LineFileDocs(random())) {
Review comment:
Hmm, could we also let the `LineFileDocs` based test remain, in addition to
the new tests? I find it to be a good way to do random tests on realistic(ish)
data sets.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
