atris commented on a change in pull request #904: LUCENE-8992: Share minimum
score across segment in concurrent search
URL: https://github.com/apache/lucene-solr/pull/904#discussion_r329925324
##########
File path:
lucene/core/src/java/org/apache/lucene/search/TopScoreDocCollector.java
##########
@@ -139,7 +140,8 @@ public void collect(int doc) throws IOException {
if (score > after.score || (score == after.score && doc <=
afterDoc)) {
// hit was collected on a previous page
- if (totalHitsRelation == TotalHits.Relation.EQUAL_TO &&
hitsThresholdChecker.isThresholdReached()) {
+ if ((totalHitsRelation == TotalHits.Relation.EQUAL_TO ||
shouldUpdateMinScore())
Review comment:
I am not really sure if we need `shouldUpdateMinScore` here -- it would be
called anyway if the global threshold is reached. Is the objective to reduce
the number of redundant calls to `updateMinCompetitiveScore` i.e. only call
when we know that we have a better global score?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
