atris commented on a change in pull request #904: LUCENE-8992: Share minimum
score across segment in concurrent search
URL: https://github.com/apache/lucene-solr/pull/904#discussion_r330360878
##########
File path:
lucene/core/src/java/org/apache/lucene/search/TopScoreDocCollector.java
##########
@@ -139,7 +140,8 @@ public void collect(int doc) throws IOException {
if (score > after.score || (score == after.score && doc <=
afterDoc)) {
// hit was collected on a previous page
- if (totalHitsRelation == TotalHits.Relation.EQUAL_TO &&
hitsThresholdChecker.isThresholdReached()) {
+ if ((totalHitsRelation == TotalHits.Relation.EQUAL_TO ||
shouldUpdateMinScore())
Review comment:
I am not sure if I understand. If a collector is only seeing non competitive
hits, it would not be able to contribute to the global minimum score?
On the other hand, if the local minimum score is enough to filter out non
competitive hits but not good enough to beat the current global minimum, we
could run with the local score and let it be the sentinel of the collector's
bottom score.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
