atris commented on a change in pull request #904: LUCENE-8992: Share minimum
score across segment in concurrent search
URL: https://github.com/apache/lucene-solr/pull/904#discussion_r329928279
##########
File path: lucene/core/src/java/org/apache/lucene/search/TopFieldCollector.java
##########
@@ -318,18 +327,35 @@ private TopFieldCollector(FieldValueHitQueue<Entry> pq,
int numHits,
scoreMode = needsScores ? ScoreMode.COMPLETE :
ScoreMode.COMPLETE_NO_SCORES;
canSetMinScore = false;
}
+ this.bottomValueChecker = bottomValueChecker;
}
@Override
public ScoreMode scoreMode() {
return scoreMode;
}
+ protected boolean shouldUpdateMinScore() {
Review comment:
Should we call it `betterGlobalScoreAvailable`, since the minimum score
could still be left unchanged (if the threshold is not reached, for eg?)
Another idea is to refactor `updateMinCompetitiveScore` to be split into two
discrete methods, so that `shouldUpdateMinScore` can be extended to also update
the score?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
