sigram commented on a change in pull request #2040:
URL: https://github.com/apache/lucene-solr/pull/2040#discussion_r513469553
##########
File path: solr/core/src/java/org/apache/solr/cloud/Overseer.java
##########
@@ -173,6 +175,9 @@
private final Stats zkStats;
+ private final SolrMetricManager metricManager = new SolrMetricManager();
Review comment:
This is wrong - you should never create instances of SolrMetricManager
in your components. Always use the single instance constructed in
`CoreContainer.getMetricManager()`.
The only reason it kind of worked for you was that you made it a shared
registry, which is created once per JVM - but as I explain below in this case a
shared registry is incorrect and should not be used.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
