megancarey commented on a change in pull request #2040:
URL: https://github.com/apache/lucene-solr/pull/2040#discussion_r513744141
##########
File path: solr/core/src/java/org/apache/solr/cloud/Overseer.java
##########
@@ -636,7 +650,7 @@ public synchronized void start(String id) {
ThreadGroup ccTg = new ThreadGroup("Overseer collection creation
process.");
OverseerNodePrioritizer overseerPrioritizer = new
OverseerNodePrioritizer(reader, getStateUpdateQueue(), adminPath,
shardHandler.getShardHandlerFactory());
- overseerCollectionConfigSetProcessor = new
OverseerCollectionConfigSetProcessor(reader, id, shardHandler, adminPath,
stats, Overseer.this, overseerPrioritizer);
+ overseerCollectionConfigSetProcessor = new
OverseerCollectionConfigSetProcessor(reader, id, shardHandler, adminPath,
stats, Overseer.this, overseerPrioritizer, solrMetricsContext);
Review comment:
Are there any tests that instantiate
OverseerCollectionConfigSetProcessor? (Just want to make sure this is the only
time this method is used, since we changed the signature)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
