saatchibhalla commented on a change in pull request #2040:
URL: https://github.com/apache/lucene-solr/pull/2040#discussion_r513772094



##########
File path: solr/solr-ref-guide/src/metrics-reporting.adoc
##########
@@ -53,6 +53,12 @@ This registry is returned at `solr.jvm` and includes the 
following information.
 * System properties such as Java information, various installation directory 
paths, ports, and similar information. You can control what appears here by 
modifying `solr.xml`.
 // TODO for 7.0 fix this
 
+=== Overseer Registry

Review comment:
       chose to leave it this way - although we're using MetricManager from 
CoreContainer i'm still registering these metrics under "solr.overseer." 




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org

Reply via email to