megancarey commented on a change in pull request #2040:
URL: https://github.com/apache/lucene-solr/pull/2040#discussion_r513632682



##########
File path: solr/core/src/java/org/apache/solr/cloud/Overseer.java
##########
@@ -185,6 +190,9 @@ public ClusterStateUpdater(final ZkStateReader reader, 
final String myId, Stats
       this.completedMap = getCompletedMap(zkClient);
       this.myId = myId;
       this.reader = reader;
+
+      registryName = 
SolrMetricManager.getRegistryName(SolrInfoBean.Group.overseer);
+      metricManager.registerGauge(null, registryName, () -> 
stateUpdateQueue.getZkStats().getQueueLength(), "overseer", true, 
"stateUpdateQueueSize", "queue");

Review comment:
       @sigram Thanks for the feedback! Is there documentation around adding 
metrics that covers things like this? 




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org

Reply via email to