saatchibhalla commented on pull request #2040:
URL: https://github.com/apache/lucene-solr/pull/2040#issuecomment-738118886


   > Saatchi; could you please comment here what this change in the config is 
about? Did you blend two metrics into one, and if so why? Maybe could you share 
a snippet of the prometheus exporter's output so we know clearly what the 
output of this "looks like"
   
   Hey David, sorry for the delay in getting back to you. I looked at this 
again, and decided that the two overseer queue metrics should be exported as 
separate metrics (rather than grouping them together under a single exported 
metric). Each of these queues represent separate responsibilities of the 
Overseer, and this allows for more flexibility in the future to add more 
metrics for each queue and group those together per queue. 
   
   Based on the current status of solr-exporter.xml this is how the exported 
metrics will look:
   {
     "name": "solr_metrics_overseer_stateUpdateQueueSize",
     "type": "GAUGE",
     "help": "See following URL: 
https://lucene.apache.org/solr/guide/metrics-reporting.html";,
     "label_names": [],
     "label_values": [],
     "value": 0
   }
   {
     "name": "solr_metrics_overseer_collectionWorkQueueSize",
     "type": "GAUGE",
     "help": "See following URL: 
https://lucene.apache.org/solr/guide/metrics-reporting.html";,
     "label_names": [],
     "label_values": [],
     "value": 0
   }


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org

Reply via email to