zacharymorn commented on a change in pull request #25:
URL: https://github.com/apache/lucene/pull/25#discussion_r599171189



##########
File path: lucene/facet/src/java/org/apache/lucene/facet/FacetsConfig.java
##########
@@ -408,7 +475,7 @@ private void processSSDVFacetFields(
         doc.add(new StringField(indexFieldName, fullPath, Field.Store.NO));

Review comment:
       I think this would function like the existing behavior since I made the 
corresponding changes for setting `requireDimensionDrillDown`:
   
   ```
     /**
      * Specify whether drill down on the dimension is necessary.
      *
      * @deprecated Use {@link FacetsConfig#setDrillDownTermsIndexing(String, 
DrillDownTermsIndexing)}
      *     instead
      */
     @Deprecated
     public synchronized void setRequireDimensionDrillDown(String dimName, 
boolean v) {
       DimConfig ft = fieldTypes.get(dimName);
       if (ft == null) {
         ft = new DimConfig();
         fieldTypes.put(dimName, ft);
       }
   
       ft.drillDownTermsIndexing =
           v ? DrillDownTermsIndexing.ALL : 
DrillDownTermsIndexing.ALL_PATHS_NO_DIM; // drillDownTermsIndexing = true is 
now drillDownTermsIndexing = DrillDownTermsIndexing.ALL
     }
   ```
   
   but I guess a relevant question would be, do we want to support different 
indexing options here as well like in `processFacetFields` ? My understanding 
is this method is not used for taxonomy faceting, so we may not need to add 
indexing for drill down terms, but I may be wrong. What do you think 
@mikemccand ?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to