gsmiller commented on a change in pull request #25:
URL: https://github.com/apache/lucene/pull/25#discussion_r599195582



##########
File path: lucene/facet/src/java/org/apache/lucene/facet/FacetsConfig.java
##########
@@ -408,7 +475,7 @@ private void processSSDVFacetFields(
         doc.add(new StringField(indexFieldName, fullPath, Field.Store.NO));

Review comment:
       Yeah, these are interesting because they can't really honor all the 
options you've introduced in the new enum right? The enum is pretty centered 
around the taxonomy use-case, but then these other two sneak in.
   
   These other two (SSDV and AssociationFacet) can honor NONE, FULL_PATH_ONLY 
and DIMENSION_AND_FULL_PATH, but the other two options are weird because there 
aren't cases (that I'm aware of anyway) for indexing partial paths. Hmm. Well, 
at a minimum, I think they should honor those first three options. The current 
behavior is either DIMENSION_AND_FULL_PATH or FULL_PATH_ONLY, and NONE would be 
trivial to add. Need a little more thought on the other two. Maybe Mike has 
some additional ideas :)




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to