zacharymorn commented on a change in pull request #25:
URL: https://github.com/apache/lucene/pull/25#discussion_r600112770



##########
File path: lucene/facet/src/java/org/apache/lucene/facet/FacetsConfig.java
##########
@@ -168,14 +203,34 @@ public synchronized void setIndexFieldName(String 
dimName, String indexFieldName
     ft.indexFieldName = indexFieldName;
   }
 
-  /** Specify whether drill down on just the dimension is necessary. */
+  /**
+   * Specify whether drill down on the dimension is necessary.
+   *
+   * @deprecated Use {@link FacetsConfig#setDrillDownTermsIndexing(String, 
DrillDownTermsIndexing)}
+   *     instead
+   */
+  @Deprecated
   public synchronized void setRequireDimensionDrillDown(String dimName, 
boolean v) {

Review comment:
       I think we do. The implementation change in 
`setRequireDimensionDrillDown` should behave like the existing one (keeping or 
skipping indexing for dim only), existing tests passed (in particular 
`testRequireDimensionDrillDown`) and there are new tests added to verify the 
default scenarios (e.g. `testDrillDownTermsDefaultWithHierarchicalSetting`).  
Is back-porting something only Lucene committers can do, or I can help out as 
well?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to