zacharymorn commented on a change in pull request #25:
URL: https://github.com/apache/lucene/pull/25#discussion_r600111781



##########
File path: lucene/facet/src/java/org/apache/lucene/facet/FacetsConfig.java
##########
@@ -408,7 +475,7 @@ private void processSSDVFacetFields(
         doc.add(new StringField(indexFieldName, fullPath, Field.Store.NO));

Review comment:
       Sounds good. I've added support for these options for SSDV as well in 
the latest commits. Actually during implementation I noticed there are test 
assertions for drill down for SSDV already, so I guess there's already overlap 
between the two (do we want to combine the overlap though?).




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to