sgup432 commented on PR #15805: URL: https://github.com/apache/lucene/pull/15805#issuecomment-4033523819
Pretty neat! Looking at the StringHelper code, I also wonder whether we could avoid using BigInteger since randomId is fixed at 128 bits, and instead replace it with two AtomicLongs? Though will sacrifice readability. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
