rmuir commented on PR #15805: URL: https://github.com/apache/lucene/pull/15805#issuecomment-4055905023
> In addition, out of curiosity, to learn more, what tools are you referring to? making synchronized looks like a bottleneck though it might not be? and Lucene has to compromise and adapt? Yeah, I feel like its the "bad sampling profilers" :) I don't know if these are ones people just have convenient in their IDE or what. But anytime we've added "simple synchronized()" somewhere, end result is, we've always have gotten tons of reports about it being a bottleneck. So I'm just mentioning the social/practical side of removing synchronized. Even if it is a bit slower, it can save human time. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
