rmuir commented on PR #15805: URL: https://github.com/apache/lucene/pull/15805#issuecomment-4054983162
yeah, unfortunately, we can't make something `synchronized` in open-source java, like ever. otherwise we'll get a constant stream of false reports about how its the "bottleneck". this is because of many broken profilers and tools. Anything "synchronized" will create "profiler ghosts" across all kinds of shitty tools. It is something severely broken about java ecosystem itself and the developers and tools that use it. So I prefer removing the synchronized, even if its slower, as long as the code can be kept SIMPLE. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
