neoremind commented on PR #15805: URL: https://github.com/apache/lucene/pull/15805#issuecomment-4065210441
@rmuir Thanks for the explanation. I spent some time diving into the profiling caveats you raised, I now have a much better understanding of where profiling tools may be short as you pointed around `synchronized` and safepoints. And I agree your insight on trusting kernel perf is well stood, and the "profiler ghost" maintenance cost makes sense to me :) This PR may not be the best example, but I think the broader takeaway stands that `synchronized` is worth scrutinizing (particularly in hot spot path), not soley for performance, but to better position maintainers upon those misdiagnose-prone profiler reports. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
