hunyadi-dev commented on a change in pull request #1020:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1020#discussion_r585340393
##########
File path: extensions/librdkafka/rdkafka_utils.h
##########
@@ -47,7 +47,7 @@ struct rd_kafka_conf_deleter {
struct rd_kafka_producer_deleter {
void operator()(rd_kafka_t* ptr) const noexcept {
- rd_kafka_resp_err_t flush_ret = rd_kafka_flush(ptr, 10000 /* ms */); //
Matching the wait time of KafkaConnection.cpp
+ // rd_kafka_resp_err_t flush_ret = rd_kafka_flush(ptr, 10000 /* ms */);
// Matching the wait time of KafkaConnection.cpp
Review comment:
Why did you comment this out?
This is part of the proper termination sequence:
https://github.com/edenhill/librdkafka/blob/master/INTRODUCTION.md#termination
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
