lordgamez commented on a change in pull request #1020:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1020#discussion_r585491374
##########
File path: extensions/standard-processors/processors/GenerateFlowFile.cpp
##########
@@ -87,7 +87,7 @@ void generateData(std::vector<char>& data, bool textData =
false) {
std::uniform_int_distribution<> distr(0, index_of_last_char);
auto rand = std::bind(distr, eng);
std::generate_n(data.begin(), data.size(), rand);
- std::for_each(data.begin(), data.end(), [](char & c) { c =
TEXT_CHARS[c];});
+ std::for_each(data.begin(), data.end(), [](char & c) { c =
TEXT_CHARS[static_cast<uint8_t>(c)];});
Review comment:
Sorry I'm not sure what do you mean here. Could you give a code
example/suggestion?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
