hunyadi-dev commented on a change in pull request #1020:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1020#discussion_r585523452
##########
File path: nanofi/include/sitetosite/CRawSocketProtocol.h
##########
@@ -76,23 +76,15 @@ int16_t sendPacket(struct CRawSiteToSiteClient * client,
const char * transactio
CTransaction* createTransaction(struct CRawSiteToSiteClient * client,
TransferDirection direction);
-static const char * getResourceName() {
+static inline const char * getResourceName() {
Review comment:
Why all the explicit inlining?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]