fgerlits commented on a change in pull request #1234:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1234#discussion_r781093736
##########
File path: thirdparty/kubernetes-client-c/remove-findpackage.patch
##########
@@ -0,0 +1,12 @@
+diff --git a/kubernetes/PreTarget.cmake b/kubernetes/PreTarget.cmake
+index 93ea00e..1e064b8 100644
+--- a/kubernetes/PreTarget.cmake
++++ b/kubernetes/PreTarget.cmake
+@@ -41,6 +41,3 @@ list(APPEND HDRS
+ websocket/kube_exec.h
+ include/generic.h
+ include/utils.h)
+-
+-find_package(libwebsockets CONFIG REQUIRED)
+-find_package(yaml CONFIG REQUIRED)
Review comment:
I think adding `Find*.cmake` files would only work for `find_package` in
`MODULE` mode, and this is `CONFIG` mode, so CMake is looking for
`yamlConfig.cmake` and `libwebsockets-config.cmake`. These are, in fact,
generated by CMake (at `build/_deps/yaml-build/CMakeFiles/yamlConfig.cmake` in
the case of `libyaml`), but I haven't found a way of making CMake look for it
there. This issue: https://gitlab.kitware.com/cmake/cmake/-/issues/21687 may
be about adding this capability to CMake, but it has not been resolved.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
