szaszm commented on a change in pull request #1234:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1234#discussion_r781102391
##########
File path: thirdparty/kubernetes-client-c/remove-findpackage.patch
##########
@@ -0,0 +1,12 @@
+diff --git a/kubernetes/PreTarget.cmake b/kubernetes/PreTarget.cmake
+index 93ea00e..1e064b8 100644
+--- a/kubernetes/PreTarget.cmake
++++ b/kubernetes/PreTarget.cmake
+@@ -41,6 +41,3 @@ list(APPEND HDRS
+ websocket/kube_exec.h
+ include/generic.h
+ include/utils.h)
+-
+-find_package(libwebsockets CONFIG REQUIRED)
+-find_package(yaml CONFIG REQUIRED)
Review comment:
According to the `find_package` docs, you could set `<PackageName>_ROOT`
(`libwebsockets_ROOT` and `yaml_ROOT` in this case) to this directory and it
would be found by `find_package`. The issue is about doing this automatically
in cmake.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
