fgerlits commented on a change in pull request #1234:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1234#discussion_r781099262
##########
File path: cmake/BundledLibreSSL.cmake
##########
@@ -60,6 +60,7 @@ function(use_libre_ssl SOURCE_DIR BINARY_DIR)
# Set variables
set(OPENSSL_FOUND "YES" CACHE STRING "" FORCE)
set(OPENSSL_INCLUDE_DIR "${LIBRESSL_BIN_DIR}/include" CACHE STRING ""
FORCE)
+ set(OPENSSL_INCLUDE_DIRS "${OPENSSL_INCLUDE_DIR}" CACHE STRING "" FORCE)
# workaround for libwebsockets
Review comment:
I think this is more a bug in `libwebsockets`. It should be reading
`OPENSSL_INCLUDE_DIR`, but (in the case when OpenSSL is part of the project
being compiled and not installed on the system) it looks for
`OPENSSL_INCLUDE_DIRS` instead.
A better solution may be to patch `libwebsockets` to correctly look for
`OPENSSL_INCLUDE_DIR` (and submit the patch upstream). Do you think it's worth
doing that?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
