szaszm commented on a change in pull request #1234:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1234#discussion_r781113929
##########
File path: cmake/BundledLibreSSL.cmake
##########
@@ -60,6 +60,7 @@ function(use_libre_ssl SOURCE_DIR BINARY_DIR)
# Set variables
set(OPENSSL_FOUND "YES" CACHE STRING "" FORCE)
set(OPENSSL_INCLUDE_DIR "${LIBRESSL_BIN_DIR}/include" CACHE STRING ""
FORCE)
+ set(OPENSSL_INCLUDE_DIRS "${OPENSSL_INCLUDE_DIR}" CACHE STRING "" FORCE)
# workaround for libwebsockets
Review comment:
According to
[this](https://discourse.cmake.org/t/findboost-difference-between-boost-include-dir-and-boost-include-dirs/855),
INCLUDE_DIR is its own include dir while INCLUDE_DIRS is all of the include
dirs needed to use the project, at least in case of Boost. [They are
identical](https://github.com/Kitware/CMake/blob/master/Modules/FindBoost.cmake#L2351),
though, so I'm not sure if that's actually the case.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
