lordgamez commented on a change in pull request #1234:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1234#discussion_r781108443
##########
File path: cmake/BundledLibreSSL.cmake
##########
@@ -60,6 +60,7 @@ function(use_libre_ssl SOURCE_DIR BINARY_DIR)
# Set variables
set(OPENSSL_FOUND "YES" CACHE STRING "" FORCE)
set(OPENSSL_INCLUDE_DIR "${LIBRESSL_BIN_DIR}/include" CACHE STRING ""
FORCE)
+ set(OPENSSL_INCLUDE_DIRS "${OPENSSL_INCLUDE_DIR}" CACHE STRING "" FORCE)
# workaround for libwebsockets
Review comment:
I'm not sure if it's a bug or not because I saw that in case of other
3rd party libraries both *INCLUDE_DIR and *INCLUDE_DIRS variables are defined
being interchangeable. That's why I thought this might be the case here too, so
it would worth defining both if any other library would use either of them. If
it's actually a bug I think this workaround is okay it's not worth patching it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
