fgerlits commented on a change in pull request #1234:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1234#discussion_r781210996
##########
File path: thirdparty/kubernetes-client-c/remove-findpackage.patch
##########
@@ -0,0 +1,12 @@
+diff --git a/kubernetes/PreTarget.cmake b/kubernetes/PreTarget.cmake
+index 93ea00e..1e064b8 100644
+--- a/kubernetes/PreTarget.cmake
++++ b/kubernetes/PreTarget.cmake
+@@ -41,6 +41,3 @@ list(APPEND HDRS
+ websocket/kube_exec.h
+ include/generic.h
+ include/utils.h)
+-
+-find_package(libwebsockets CONFIG REQUIRED)
+-find_package(yaml CONFIG REQUIRED)
Review comment:
Thanks, I did not know about the `*_ROOT` variable. I have tried to
make this work, but
* I still need to patch the kubernetes lib to set the
[CMP0074](https://cmake.org/cmake/help/latest/policy/CMP0074.html) policy to
NEW, and
* the generated `yamlConfig.cmake` and `libwebsockets-config.cmake` files
don't quite work: `yamlConfig.cmake` refers to a `yamlTargets.cmake` file which
does not exist, and `libwebsockets-config.cmake` tries to `include()`
`LibwebsocketsTargets.cmake`, which does exist, but CMake says it "was
generated by the export() command. It may not be used as the argument to the
include() command. Use ALIAS targets instead to refer to targets by
alternative names."
I'm sure all these problems could be solved, but at this point I think the
least messy solution is to leave this as it is.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
