fgerlits commented on code in PR #1334:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1334#discussion_r887841392
##########
libminifi/src/core/Connectable.cpp:
##########
@@ -85,7 +69,7 @@ bool Connectable::isSupportedRelationship(const
core::Relationship &relationship
}
}
-bool Connectable::setAutoTerminatedRelationships(const std::set<Relationship>
&relationships) {
+bool Connectable::setAutoTerminatedRelationships(const
std::vector<Relationship>& relationships) {
Review Comment:
I changed `setAutoTerminatedRelationships` to a template in
529f7014bdaf548ebfd5198cd78cdd5ff9b5b136
but then I realized it doesn't need to be a template, and changed
`setSupportedProperties`, `setSupportedRelationships` and
`setAutoTerminatedRelationships` back to functions, with a `gsl::span` argument
type, in cb2e0defeb0d19539590fe82cd6eb69e466ca2dc
let me know if you don't like cb2e0defeb0d19539590fe82cd6eb69e466ca2dc and
want it changed back
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
