adamdebreceni commented on code in PR #1334:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1334#discussion_r887874442
##########
libminifi/src/core/Connectable.cpp:
##########
@@ -85,7 +69,7 @@ bool Connectable::isSupportedRelationship(const
core::Relationship &relationship
}
}
-bool Connectable::setAutoTerminatedRelationships(const std::set<Relationship>
&relationships) {
+bool Connectable::setAutoTerminatedRelationships(const
std::vector<Relationship>& relationships) {
Review Comment:
I'm fine with `gsl::span` my only concern is from the caller's side we
injected a number of `std::array` calls where previously we used an initializer
list, do we need them or can we drop them now that the methods are not
templates?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
