fgerlits commented on code in PR #1334:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1334#discussion_r888187635
##########
run_clang_tidy.sh:
##########
@@ -5,7 +5,14 @@ set -uo pipefail
exit_code=0
FILES=$1
+EXCLUDED_EXTENSIONS=("pdh", "windows-event-log", "tensorflow")
+
for changed_file in ${FILES}; do
+ for extension in "${EXCLUDED_EXTENSIONS[@]}"; do
+ if [[ "${changed_file}" =~ extensions/${extension}/ ]]; then
+ continue 2
+ fi
+ done
if [[ "${changed_file}" == *.cpp ]]; then
clang-tidy-14 -warnings-as-errors=* -quiet -p build "${changed_file}"
Review Comment:
I have added this as a quick-and dirty way of skipping the Windows-only
extensions. @lordgamez please let me know if you can think of a better way.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
