fgerlits commented on code in PR #1334:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1334#discussion_r890872361
##########
libminifi/src/core/Connectable.cpp:
##########
@@ -85,7 +69,7 @@ bool Connectable::isSupportedRelationship(const
core::Relationship &relationship
}
}
-bool Connectable::setAutoTerminatedRelationships(const std::set<Relationship>
&relationships) {
+bool Connectable::setAutoTerminatedRelationships(const
std::vector<Relationship>& relationships) {
Review Comment:
I prefer `some_function(std::array{foo, bar})` to `some_function({foo,
bar})`; I think it's clearer and it's also slightly more efficient. The only
downside is a few more characters, but I don't think that's a problem.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
