martinzink commented on code in PR #1612:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1612#discussion_r1270851594
##########
libminifi/include/utils/FlatMap.h:
##########
@@ -282,20 +290,18 @@ class FlatMap{
return data_.max_size();
}
- bool empty() const noexcept {
+ [[nodiscard]] bool empty() const noexcept {
return data_.empty();
}
- bool contains(const K& key) const {
+ template<typename T>
+ requires std::equality_comparable_with<K, T>
+ bool contains(const T& key) const {
Review Comment:
good idea, changed it and the others (except for operator[]) in
https://github.com/apache/nifi-minifi-cpp/pull/1612/commits/f2092883c378f21a8d7ec2ab53c3826bcbef07c2
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
