adamdebreceni commented on code in PR #1612:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1612#discussion_r1272174502
##########
extensions/libarchive/CompressContent.cpp:
##########
@@ -88,7 +88,7 @@ void CompressContent::processFlowFile(const
std::shared_ptr<core::FlowFile>& flo
std::string attr;
flowFile->getAttribute(core::SpecialFlowAttribute::MIME_TYPE, attr);
if (attr.empty()) {
- logger_->log_error("No %s attribute existed for the flow, route to
failure", core::SpecialFlowAttribute::MIME_TYPE);
+ logger_->log_error("No %s attribute existed for the flow, route to
failure", core::SpecialFlowAttribute::MIME_TYPE.data());
Review Comment:
based on the standard it should be safe as `std::string_view::data` returns
`s` if constructed from `std::string_view::string_view(const char* s)`, but
agree that playing it safe could not hurt
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
