martinzink commented on code in PR #1612:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1612#discussion_r1270852692
##########
extensions/libarchive/CompressContent.cpp:
##########
@@ -88,7 +88,7 @@ void CompressContent::processFlowFile(const
std::shared_ptr<core::FlowFile>& flo
std::string attr;
flowFile->getAttribute(core::SpecialFlowAttribute::MIME_TYPE, attr);
if (attr.empty()) {
- logger_->log_error("No %s attribute existed for the flow, route to
failure", core::SpecialFlowAttribute::MIME_TYPE);
+ logger_->log_error("No %s attribute existed for the flow, route to
failure", core::SpecialFlowAttribute::MIME_TYPE.data());
Review Comment:
you are right, good catch changed it in
https://github.com/apache/nifi-minifi-cpp/pull/1612/commits/0b50c8b3c9a35f245d4a606d84f4fbd3634f54e5
It would be good if our logger would accept string_view directly but thats
for a new PR (maybe we could switch to fmt style aswell)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
