szaszm commented on code in PR #1612: URL: https://github.com/apache/nifi-minifi-cpp/pull/1612#discussion_r1272226766
########## libminifi/include/utils/FlatMap.h: ########## Review Comment: I don't know why I originally suggested this, I think I just prefer avoiding templates in the common case. One thing it could theoretically help with is allowing conversions to the key type, when the source type is not equality comparable to the key type, but convertible to it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
