szaszm commented on code in PR #1612: URL: https://github.com/apache/nifi-minifi-cpp/pull/1612#discussion_r1272226766
########## libminifi/include/utils/FlatMap.h: ########## Review Comment: I don't know why I originally suggested this, I think I just prefer avoiding templates in the common case. One thing it could theoretically help with is allowing conversions to the key type, when the source type is not equality comparable to the key type, but convertible to it. Maybe it can also help with some ambiguous cases as well, since non-templates take precedence over templates, but I may be confusing this with another arrangement. Ultimately it's your call whether you want to change it or not. I'm not blocking anything unless it's clearly and unambiguously wrong. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
