Github user achristianson commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/134#discussion_r137835890
--- Diff: libminifi/include/ResourceClaim.h ---
@@ -83,13 +83,19 @@ class ResourceClaim : public
std::enable_shared_from_this<ResourceClaim> {
}
void deleteClaim() {
- if (!deleted_)
- {
+ if (!deleted_) {
deleted_ = true;
}
}
+ bool exists(){
+ if (claim_manager_ == nullptr){
+ return false;
--- End diff --
This could lead to subtle bugs where a programming error (not
setting/initializing claim_manager_) would appear as a runtime state or error
condition (file lost/doesn't exist).
---
