Github user achristianson commented on a diff in the pull request:

    https://github.com/apache/nifi-minifi-cpp/pull/134#discussion_r137879427
  
    --- Diff: libminifi/include/processors/InvokeHTTP.h ---
    @@ -101,9 +105,9 @@ class InvokeHTTP : public core::Processor {
       static core::Relationship RelNoRetry;
       static core::Relationship RelFailure;
     
    -  void onTrigger(core::ProcessContext *context, core::ProcessSession 
*session);
    -  void initialize();
    -  void onSchedule(core::ProcessContext *context, 
core::ProcessSessionFactory *sessionFactory);
    +  virtual void onTrigger(core::ProcessContext *context, 
core::ProcessSession *session);
    +  virtual void initialize();
    +  virtual void onSchedule(core::ProcessContext *context, 
core::ProcessSessionFactory *sessionFactory);
    --- End diff --
    
    Probably want to use override instead of virtual.


---

Reply via email to