bakaid commented on a change in pull request #713: MINIFICPP-1119 unify win/posix sockets + clean up issues URL: https://github.com/apache/nifi-minifi-cpp/pull/713#discussion_r377174252
########## File path: libminifi/src/io/ServerSocket.cpp ########## @@ -18,21 +18,15 @@ #include "io/ServerSocket.h" #include "io/DescriptorStream.h" -#include <sys/types.h> #ifndef WIN32 -#include <netinet/tcp.h> -#include <netdb.h> -#include <sys/socket.h> +#include <sys/types.h> #include <netinet/in.h> -#include <arpa/inet.h> Review comment: This include is required for `htons`, used by `Socket::createConnection`. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
