bakaid commented on a change in pull request #713: MINIFICPP-1119 unify
win/posix sockets + clean up issues
URL: https://github.com/apache/nifi-minifi-cpp/pull/713#discussion_r377122116
##########
File path: libminifi/include/io/BaseStream.h
##########
@@ -175,13 +174,12 @@ class BaseStream : public DataStream, public
Serializable {
**/
virtual int read(uint64_t &value, bool is_little_endian =
EndiannessCheck::IS_LITTLE);
- virtual const uint64_t getSize() const {
+ virtual uint64_t getSize() const {
Review comment:
This breaks API.
The original one does not make sense, and I agree with this change, but we
can't break the API in a minor release, especially an API very likely used in
the wild.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
