bakaid commented on a change in pull request #713: MINIFICPP-1119 unify
win/posix sockets + clean up issues
URL: https://github.com/apache/nifi-minifi-cpp/pull/713#discussion_r377151885
##########
File path: libminifi/src/io/StreamFactory.cpp
##########
@@ -38,35 +39,21 @@ namespace io {
template<typename T, typename V>
class SocketCreator : public AbstractStreamFactory {
- template<bool cond, typename U>
Review comment:
I understand that these were noops in this form, but could you decipher the
original intent? (Not the implementation reality.)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
